Skip to content

improve the generic signatures for singleton types #24288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

improve the generic signatures for singleton types #24288

merged 1 commit into from
Oct 29, 2025

Conversation

@hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Oct 28, 2025

When generating the generic signature of a singleton type, instead of relying on the erased type, generate it from its underlying type.

Closes #24272

hamzaremmal
hamzaremmal commented Oct 28, 2025
View reviewed changes
tests/run/i24272.check
@@ -0,0 +1 @@
public <B> B Foo.bar(B)
Copy link
Member Author

@hamzaremmal hamzaremmal Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was public <B> java.lang.Object Foo.bar(B) before.

@hamzaremmal hamzaremmal marked this pull request as ready for review October 28, 2025 14:48
@hamzaremmal hamzaremmal requested review from lrytz and sjrd October 28, 2025 14:48
sjrd
sjrd approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a coding style comment. Otherwise LGTM.

@hamzaremmal hamzaremmal enabled auto-merge October 29, 2025 12:08
@tgodzik tgodzik added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Oct 29, 2025
@noti0na1
Copy link
Member

noti0na1 commented Oct 29, 2025

What about singleton types inside type arguments?

@hamzaremmal hamzaremmal merged commit 6b3569d into scala:main Oct 29, 2025
51 checks passed
@hamzaremmal hamzaremmal deleted the i24272 branch October 29, 2025 16:53
@WojciechMazur WojciechMazur added this to the 3.8.0 milestone Oct 29, 2025
@hamzaremmal
Copy link
Member Author

hamzaremmal commented Oct 29, 2025

What about singleton types inside type arguments?

Can you write an example where it doesn't work?

I know that my PR doesn't cover this for example:

class Foo[T]:
  val x: T = ???
  def foo: x.type = ???

I meant to create a separate issue for it and just fix the one I linked here.

@WojciechMazur WojciechMazur mentioned this pull request Nov 12, 2025
Merged
WojciechMazur added a commit that referenced this pull request Nov 12, 2025
@WojciechMazur
Backport "improve the generic signatures for singleton types" to 3.8.0 (
50906b1 
#24389)

Backports #24288 to the 3.8.0-RC1.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lrytz lrytz lrytz approved these changes

@sjrd sjrd sjrd approved these changes

Assignees

@lrytz lrytz

@sjrd sjrd

Labels

backport:done This PR was successfully backported.

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

Java generic signature of paths can be improved

6 participants

@hamzaremmal @noti0na1 @lrytz @sjrd @tgodzik @WojciechMazur